Return added row and col IDs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o add-row-col-directly
|
Argh, now that would require a major version bump :/ If you had included that in your initial pull request, we could have stayed on v1 Now either we break semver, or we require all users to change their version requirements. |
|
Sorry, I only noticed after it was merged. I think it's low risk if you decide on breaking semver, it has only been 6 hours since the version bump, and crates.io shows only 18 downloads. |
lovasoa
added a commit
that referenced
this pull request
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
add_rowmethod to be useful the user must have access to the column indices (check the test). I also returned row IDs it might be useful in the future.