-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker: 0.8 release #889
Comments
Could |
Yes, I guess we can do that. Similar to |
By the way, if any observers wish to help get this release ready sooner, one of the easiest ways to contribute may be to review pull requests. So long as you have some familiarity with the Rust language and Rand's API, reviews may be useful. |
I think updating to |
Thanks for pushing to get a lot of changes for 0.8 finished @vks. I guess we can be flexible on the "Multiple distributions & naming" items. At the moment it's not obvious (to me) whether we'll want a 0.9 release with more breaking changes before 1.0. It may be nice to essentially make 0.9 the beta for 1.0. I don't envision too many more changes needed to the core |
We should probably also deprecate
I agree that |
Another thing to consider for this release is adding support for entropy-efficient bool generation to |
I updated the tracker and opened #1027 and #1028 for some of the remaining issues. I added #1017 to the important issues and demoted the multiple distribution issue to nice-to-have, since we will likely implement this in After my two PRs are merged and the I don't know what the status of |
I believe @josephlr was intending on getting |
@dhardy |
PCG's main failing is that streams are too similar. Xoshiro isn't perfect either: it can struggle with mostly zero seeds. That shouldn't happen, especially since we have Lets take discussion back to #910. |
I think this is true for most non-crypto RNGs? It takes |
Yes, and not everyone realises that, which is a point in favour of deprecating |
Status on
Note that if we decide to have Would we still want |
I would prefer |
Since you are a member of the maintainers team, you should have sufficient rights.
I also think that it should be an optional dependency. |
Sounds good on keeping |
Getrandom 0.2 has been released: https://docs.rs/getrandom/0.2.0/getrandom/ |
I think we still need to release |
Not that I am aware. |
How about removing the |
That would be a pain for anyone updating to 0.8.0 that used |
This looks like it's pretty much ready to go -- is there anything I can do to help move this forward? |
You're right, I believe it is ready to go. It would be nice to have #1066 but that's definitely not a blocker. @vks @newpavlov any objections or shall I go ahead with the releases ( |
I think we should decide on #1031 (merge, close or postpone until |
I was thinking we postpone #1031, but we don't necessarily have to if it can be resolved in short order. Is there good reason to drop WinXP and stdweb support from getrandom before the rand release? Either its considered a breaking release or its not. We could even bump |
I thought about keeping |
In that case it affects |
It would've been nice to mention such changes in |
In any case, we can go ahead with the rand_core v0.6 release as well as PRNG crates. |
v0.8 has been released. |
To resolve:
rand_core::Error
type andno_std
diagnosticsrand_core:0.5.0::Error
has no raison d'etre #837gen_range
and ranges: gen_range doesn't take a Range #744, Implement Distribution for Range(Inclusive) #821 andgen_range(a, b)
->gen_range(a..b)
andgen_range(a..=b)
#1003getrandom
v0.2 (if released)StdRng
performance Simd not used for rand_chacha #1017SmallRng
or use a better algorithm (see Investigate replacements for SmallRng algorithm #910)rand_core
0.6 (Tracker: rand_core 0.6 #1029)Nice to have:
Final changes for 0.8:
ReseedingRng
tostd
(see Possible atomicity violation in reseeding register_fork_handler #911)StdRng
(see next comment)There is still scope for additional changes before 0.8; most of the above don't require a breaking release to deliver.
The text was updated successfully, but these errors were encountered: