Limit the number of shrink to fit #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
reviewed
Oct 25, 2023
|
not really a measurable improvement, I gained 1s over 16 between the best of 3 runs, but there was 5s discrepancy between the runs of the same version with the same dataset... |
This is not very important, but it seems a waste to do it for each stop time. This reduce a bit the loading time, but not in a really important way (tested on the Ile de france mobilité dataset).
antoine-de
force-pushed
the
limit_shrink
branch
from
734f542
to
9ed8b94
Compare
Tristramg
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not very important, but it seems a waste to do it for each stop time. This reduce a bit the loading time, but not in a really important way (tested on the Ile de france mobilité dataset).