Add a new RawGTFS::SourceFormat field and strip file paths.
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new SourceFormat store the fact that the GTFS has been read from a
directory or a zip.
Also strip the base path in the `files` field of the `RawGTFS`. This
way, if the data were were from a directory with:
`RawGTFS::new("some/path/to/read")`, the `files` will contains
`stops.txt` and not `some/path/to/read/stops.txt`. It's more consistent
to the way it will be if the data is read from a zip (and makes it
possible to know if the data were in a subfolder).
|
Note: I did not bump the version, I plan to add another PR bumping a dependency and removing some warnings |
Tristramg
approved these changes
Nov 8, 2023
reading from path
|
Note: I added a test to make it explicit that subdirectory does not work when reading from a path (like I though it would 😁 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new SourceFormat store the fact that the GTFS has been read from a directory or a zip.
Also strip the base path in the
filesfield of theRawGTFS. This way, if the data were were from a directory with:RawGTFS::new("some/path/to/read"), thefileswill containsstops.txtand notsome/path/to/read/stops.txt. It's more consistent to the way it will be if the data is read from a zip (and makes it possible to know if the data were in a subfolder).