Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gtfs::from_path to accept non-displayable path #161

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

Jusduil
Copy link

@Jusduil Jusduil commented Mar 2, 2024

Gtfs::from_path have where clause to force argument to implement Display.

But not called function are really want this.

It may be a relic to build a error string on RawGtfsReader::read_from_path but now it use p.display()

Copy link
Collaborator

@antoine-de antoine-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me, thanks for spotting this.

Can you update the patch version number so this can be released right away?

@Tristramg
Copy link
Collaborator

Thank you. Funny enough, I just stumbled on that exact problem right now

@Tristramg Tristramg merged commit cd0e818 into rust-transit:main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants