-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add request_interrupt_window handling #193
Open
QuarkContainer
wants to merge
2
commits into
rust-vmm:main
Choose a base branch
from
QuarkContainer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1403,6 +1403,12 @@ impl VcpuFd { | |
kvm_run.immediate_exit = val; | ||
} | ||
|
||
/// Sets the `request_interrupt_window` flag on the `kvm_run` struct associated with this vCPU to `val`. | ||
pub fn set_kvm_request_interrupt_window(&self, val: u8) { | ||
let kvm_run = self.kvm_run_ptr.as_mut_ref(); | ||
kvm_run.request_interrupt_window = val; | ||
} | ||
|
||
/// Returns the vCPU TSC frequency in KHz or an error if the host has unstable TSC. | ||
/// | ||
/// # Example | ||
|
@@ -1428,6 +1434,8 @@ impl VcpuFd { | |
} | ||
} | ||
|
||
|
||
|
||
Comment on lines
+1443
to
+1444
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think these are unintentional. |
||
/// Sets the specified vCPU TSC frequency. | ||
/// | ||
/// # Arguments | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test for this, it can be similar to the one for
set_kvm_immediate_exit
?