Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mshv-ioctls/system: Enable Direct mode stimer #131

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

praveen-pk
Copy link
Collaborator

Summary of the PR

Enable direct mode for synthetic timers. This allows synthetic timer interrupts to work early in the boot without having to wait for VMbus to be initialized.

Enable direct mode for synthetic timer. This allows synthetic timer interrupts
to work early in the boot without having to wait for VMbus to be initialized.

Signed-off-by: Praveen K Paladugu <[email protected]>
@liuw
Copy link
Member

liuw commented Mar 13, 2024

@NunoDasNeves @jinankjain @russell-islam I will leave this to you.

@russell-islam
Copy link
Collaborator

@praveen-pk Do you know which CPU register is used for this timer?

@praveen-pk
Copy link
Collaborator Author

@praveen-pk Do you know which CPU register is used for this timer?

HV_REGISTER_FEATURES (0x00000200), seems to be part of CPUID.

@jinankjain
Copy link
Collaborator

@praveen-pk Are there any performance implications by turning on the stimer?

@praveen-pk
Copy link
Collaborator Author

@praveen-pk Are there any performance implications by turning on the stimer?

If any, this should reduce the overhead of passing timer interrupts to guest. So, this change should not have any negative performance implications.

https://lore.kernel.org/all/[email protected].

@russell-islam russell-islam enabled auto-merge (rebase) March 18, 2024 16:08
@russell-islam russell-islam merged commit 1aa7c47 into rust-vmm:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants