Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhost-user-backend: Prepare v0.15.0 release #238

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

MatiasVara
Copy link
Contributor

@MatiasVara MatiasVara commented Apr 11, 2024

Summary of the PR

This release changes the dependency for virtio-queue to 0.12.0.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

slp
slp previously approved these changes Apr 11, 2024
Copy link
Collaborator

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Ablu
Copy link
Collaborator

Ablu commented Apr 11, 2024

Since virtio_queue::Queue appears in public API of vhost (for example VringState::get_queue()), it is a public dependency. So I think it should be a major bump of vhost-user-backend?

@stefano-garzarella
Copy link
Member

Since virtio_queue::Queue appears in public API of vhost (for example VringState::get_queue()), it is a public dependency. So I think it should be a major bump of vhost-user-backend?

I had the same doubt. I usually launch cargo semver-checks to check, but I'm in Korea without a laptop, so I can't :)

https://crates.io/crates/cargo-semver-checks

@Ablu
Copy link
Collaborator

Ablu commented Apr 11, 2024

I had the same doubt. I usually launch cargo semver-checks to check, but I'm in Korea without a laptop, so I can't :)

https://crates.io/crates/cargo-semver-checks

It would be great if that could pick it up, but unfortunately, it currently does not: obi1kenobi/cargo-semver-checks#447 :(.

@MatiasVara
Copy link
Contributor Author

Since virtio_queue::Queue appears in public API of vhost (for example VringState::get_queue()), it is a public dependency. So I think it should be a major bump of vhost-user-backend?

Thanks Eric for the comment. Is there any document that specifies when a major release is required? If it is a major, the release would be 0.15.0?

Thanks.

@Ablu
Copy link
Collaborator

Ablu commented Apr 11, 2024

Thanks Eric for the comment. Is there any document that specifies when a major release is required?

There is https://doc.rust-lang.org/cargo/reference/semver.html for general documentation, but in the end detail questions turn into an analysis whether a "breaking change" may happen (and what "breaking" means)... So we could analyse that in great detail to understand all the edge-cases, or we just bump the major if in doubt :).

If it is a major, the release would be 0.15.0?

Rust/Cargo considers the first non-zero number as "major" so yes, 0.15.0 would be the next major version.

This release changes the dependency for virtio-queue to 0.12.0.

Signed-off-by: Matias Ezequiel Vara Larsen <[email protected]>
@MatiasVara MatiasVara changed the title vhost-user-backend: Prepare v0.14.1 release vhost-user-backend: Prepare v0.15.0 release Apr 12, 2024
@slp slp merged commit bd6bf13 into rust-vmm:main Apr 15, 2024
31 checks passed
@stefano-garzarella
Copy link
Member

@MatiasVara @Ablu @slp thanks for the release! I see it in creates.io. I just pushed the tag and created the release here, please double-check ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants