Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-queue: Add helpers for accessing queue information #132

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

sboeuf
Copy link

@sboeuf sboeuf commented Jan 24, 2022

These helpers are meant to help crate's consumers getting and setting
information about the queue.

Signed-off-by: Sebastien Boeuf [email protected]

crates/virtio-queue/src/lib.rs Show resolved Hide resolved
crates/virtio-queue/src/lib.rs Show resolved Hide resolved
crates/virtio-queue/src/state.rs Outdated Show resolved Hide resolved
@sboeuf
Copy link
Author

sboeuf commented Jan 28, 2022

PR's ready for review.

@sboeuf sboeuf requested a review from lauralt January 28, 2022 14:21
@jiangliu
Copy link
Member

Thanks for improving the unit test logic:)

@sboeuf sboeuf force-pushed the add_queue_helpers branch 2 times, most recently from 8c197cd to 27b233e Compare January 28, 2022 15:01
crates/virtio-queue/src/queue.rs Show resolved Hide resolved
crates/virtio-queue/src/queue.rs Outdated Show resolved Hide resolved
jiangliu
jiangliu previously approved these changes Jan 28, 2022
@sboeuf
Copy link
Author

sboeuf commented Jan 28, 2022

@lauralt PR updated!

lauralt
lauralt previously approved these changes Jan 28, 2022
Copy link
Contributor

@lauralt lauralt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

crates/virtio-queue/src/queue.rs Show resolved Hide resolved
These helpers are meant to help crate's consumers getting and setting
information about the queue.

Signed-off-by: Sebastien Boeuf <[email protected]>
@sboeuf sboeuf merged commit 2ca74a6 into rust-vmm:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants