Add macOS support #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMADDR_CID_LOCAL is used for vsock loopback, and is not supported on non-linux OSes. Signed-off-by: Akira Moroo <[email protected]>
macOS does not have some constants, and it has slightly different sockaddr_vm struct from other OSes. Signed-off-by: Akira Moroo <[email protected]>
qwandor
reviewed
Apr 17, 2024
Since macOS does not have `accept4`, this commit replaces it with `accept` and `fcntl` to avoid fd leak to child processes. Signed-off-by: Akira Moroo <[email protected]>
qwandor
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS Virtualization.framework provides a VirtIO VM socket device, and a macOS guest supports vsock. This PR proposes adding macOS support.