Relax encoding requirements for CGLContextObj
#1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1640. The issue is that
CGLContextObjchanged its encoding in macOS Sonoma 14.0. The encoding of a type is something thatobjc2uses to debug-assert that the definition is written correctly, but of course, if the Rust code assumes that the encoding is one thing, and it then changes, then the debug assertion will now fail.The correct fix will land at some point in madsmtm/objc2#526, which will also help with such a problem not happening again, but we can fix the issue in the interim using the
relax-void-encodingescape-hatch.CHANGELOG.mdif knowledge of this change could be valuable to users