Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump raw-window-handle to 0.6.0 #1654

Closed
wants to merge 2 commits into from

Conversation

vially
Copy link
Contributor

@vially vially commented Dec 16, 2023

Warning

I'm still very new to Rust so please review these changes very carefully.

Marked as a draft until all platforms are implemented:

  • Linux
  • Android
  • Windows
  • macOS

Bump raw-window-handle to version 0.6.0 which introduced a couple of API changes.

  • Tested on all platforms changed (these changes affect all platforms but I'm only able to test them on Wayland)
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@vially vially marked this pull request as draft December 16, 2023 20:54
@MarijnS95
Copy link
Member

You might want to look at #1582 which is promising to do this upgrade while at the same time utilizing the new lifetime pattern.

@vially
Copy link
Contributor Author

vially commented Dec 17, 2023

Ah, I missed that part, thanks for mentioning it. In that case I'll close this pull-request and wait for #1582 to land.

@vially vially closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants