Reuse some features and code, fix inverted intradoc links #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
approved these changes
Dec 21, 2023
Found some very minor code cases that could reuse some other code. Some features also already imply/enable other features and don't need to be repeated. Some "intradoc" links were having `[]` inside backticks, meaning they won't be links but actual brackets in monospace in the final doc. Finally, the `wayland` feature needs the `egl` backend to compile and function, and was likely intended to be turned on as a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some very minor code cases that could reuse some other code. Some features also already imply/enable other features and don't need to be repeated.
Some "intradoc" links were having
[]inside backticks, meaning they won't be links but actual brackets in monospace in the final doc.Finally, the
waylandfeature needs theeglbackend to compile and function, and was likely intended to be turned on as a dependency.