Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm-bindgen v0.2 handles for web_sys::HtmlCanvasElement and web_sys::OffscreenCanvas #134

Merged
merged 14 commits into from
Sep 3, 2023
Merged

Add wasm-bindgen v0.2 handles for web_sys::HtmlCanvasElement and web_sys::OffscreenCanvas #134

merged 14 commits into from
Sep 3, 2023

Commits on Sep 2, 2023

  1. Add wasm-bindgen v0.2 handles

    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    4e71da4 View commit details
    Browse the repository at this point in the history

  2. Replace wasm-bindgen handles with real wbg objects 

    In response to feedback from the community, this sets up the wasm-
bindgen handles to use direct wasm-bindgen objects rather than
indices.

As wasm-bindgen handles are not Copy, Eq or Hash, this commit also
removes those impls from all handles.

Closes #142 as well

Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    5cca108 View commit details
    Browse the repository at this point in the history

  3. Fixup CI 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    7179e66 View commit details
    Browse the repository at this point in the history

  4. Whoops 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    ec045e5 View commit details
    Browse the repository at this point in the history

  5. Rename feature to unstable_web_handles_wbg_02 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    a9fbe05 View commit details
    Browse the repository at this point in the history

  6. Use a raw pointer instead of the direct JsValue 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    4711c95 View commit details
    Browse the repository at this point in the history

  7. Fix CI issues 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    62c92c2 View commit details
    Browse the repository at this point in the history

  8. Review comments 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    a363759 View commit details
    Browse the repository at this point in the history

  9. Fix wasm feature name and structs names

    @madsmtm
    madsmtm committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    f8b3f9d View commit details
    Browse the repository at this point in the history

  10. Re-add Copy

    @madsmtm
    madsmtm committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    4dd1c61 View commit details
    Browse the repository at this point in the history

  11. Redo web canvas examples

    @madsmtm
    madsmtm committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    8c15e15 View commit details
    Browse the repository at this point in the history

  12. Documentation tweaks

    @madsmtm
    madsmtm committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    789b26a View commit details
    Browse the repository at this point in the history

  13. Add safety comment about ABI

    @madsmtm
    madsmtm committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    a79764c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Add From impls for the new web handles

    @madsmtm
    madsmtm committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    23d2195 View commit details
    Browse the repository at this point in the history