windows: Fix MsgWaitForMultipleObjects call to wake on accessibility messages
#4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcampbell
changed the title
MsgWaitForMultipleObjects call to wake on accessibilitymessagesMsgWaitForMultipleObjects call to wake on accessibility messages
…y messages It's critical that we use `QS_ALLINPUT` here.
mwcampbell
force-pushed
the
windows-msg-wait-a11y-v0.30.x
branch
from
7300313 to
48d502f
Compare
|
Just pushed a squashed commit with a corrected message. |
|
@mwcampbell just to clarify, it doesn't break the timer stuff and just makes it work with accessibility events? Also, please open it against master, since it's usually goes there and then backported, I won't be able to merge this. |
|
Correct, it makes the existing call to |
kchibisov
reviewed
Dec 23, 2024
| @@ -749,7 +749,7 @@ fn wait_for_messages_impl( | |||
| num_handles, | |||
| raw_handles.as_ptr() as *const _, | |||
| wait_duration_ms, | |||
| QS_ALLEVENTS, | |||
| QS_ALLINPUT, | |||
There was a problem hiding this comment.
Should add a comment here to say why we use QS_ALLINPUT and not QS_ALLEVENTS, otherwise it has a chance of being reverted in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's critical that we use
QS_ALLINPUThere.I'm submitting this as a PR against the v0.30.x branch, because that's where it's easiest to verify the fix (using any program that uses the AccessKit winit adapter), and it's where we most urgently need to fix this. Should be easy to forward port to master.
Fixes #4055.
changelogmodule if knowledge of this change could be valuable to users