Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned Crossbeam's version in an attempt to address #8 #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshmarlow
Copy link

Purpose

There appears to be a breaking API change in crossbeams which duct depends on.
Building locally works correct, however, cargo install cargo-test-junit fails as indicated in #8.
This PR attempts to address this build issue.

What appears to be the cause of the failure

When building locally, Cargo.lock - which pins an older version of crossbeams - is respected.
However, according to [0], when uploading the package to crates.io, no Cargo.lock is uploaded.

I've confirmed that checking out cargo-test-junit locally and running cargo build works correctly.
However, updating Cargo.lock first (ie, cargo update; cargo build) results in the same build error as when installing.

Upgrading duct results in different build failures due to changes in the duct API. Pending someone taking the effort to upgrade cargo-test-junit to use the newer version of duct, it seems reasonable to pin the version of crossbeam in cart-test-junit's Cargo.toml file.

That being said, I do not know how to test this more thoroughly than pushing an updated package to crates.io.

[0] - https://users.rust-lang.org/t/cargo-install-and-lock-file/4203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant