Pinned Crossbeam's version in an attempt to address #8 #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There appears to be a breaking API change in
crossbeams
whichduct
depends on.Building locally works correct, however,
cargo install cargo-test-junit
fails as indicated in #8.This PR attempts to address this build issue.
What appears to be the cause of the failure
When building locally,
Cargo.lock
- which pins an older version ofcrossbeams
- is respected.However, according to [0], when uploading the package to crates.io, no
Cargo.lock
is uploaded.I've confirmed that checking out
cargo-test-junit
locally and runningcargo build
works correctly.However, updating
Cargo.lock
first (ie,cargo update; cargo build
) results in the same build error as when installing.Upgrading
duct
results in different build failures due to changes in theduct
API. Pending someone taking the effort to upgradecargo-test-junit
to use the newer version ofduct
, it seems reasonable to pin the version ofcrossbeam
incart-test-junit
'sCargo.toml
file.That being said, I do not know how to test this more thoroughly than pushing an updated package to
crates.io
.[0] - https://users.rust-lang.org/t/cargo-install-and-lock-file/4203