Skip to content

Conversation

@plaindocs
Copy link
Collaborator

I did look at Dependabot, but I don't think it quite works for this scenario.

@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for scrc-coding-guidelines failed.

Name Link
🔨 Latest commit 1b211fa
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/68f212bb75021e0008dff90e

@felix91gr
Copy link
Collaborator

Given #195 has been merged, maybe it's a good idea to revert the second commit?

@PLeVasseur
Copy link
Collaborator

Hey @plaindocs, following up here to see if you'd be able to look into the feedback.

@felix91gr
Copy link
Collaborator

@plaindocs I'm really looking forward to this! ^^

I just ran again into the need to update the FLS because it was blocking #180 and #181 today :')

@plaindocs
Copy link
Collaborator Author

I'm going to make time to look at this again, soz for the delay.

@plaindocs
Copy link
Collaborator Author

@felix91gr @PLeVasseur ok, I've got a stupid bash script which lets us decide whether to update automatically. Should be easy to connect that to GHA input/output to make the PR conditional on that. But I ran out of time today before heading off for two weeks.

Happy for someone to pick it up and finish it, or I can look when I'm back.

dest = root / "build"

args = ["-b", builder, "-d", dest / "doctrees"]
args = ["-b", builder, "-d", dest / "doctrees", "-wtest.txt"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs moving out into a flagged parameter so it doesn't happen with every build.

@plaindocs
Copy link
Collaborator Author

I've not looked into the Python version build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Automation] Update the FLS spec lock_file whenever it's trivial to do

3 participants