-
Notifications
You must be signed in to change notification settings - Fork 20
Github action to update FLS every 24 hours #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for scrc-coding-guidelines failed.
|
|
Given #195 has been merged, maybe it's a good idea to revert the second commit? |
|
Hey @plaindocs, following up here to see if you'd be able to look into the feedback. |
|
@plaindocs I'm really looking forward to this! ^^ I just ran again into the need to update the FLS because it was blocking #180 and #181 today :') |
|
I'm going to make time to look at this again, soz for the delay. |
|
@felix91gr @PLeVasseur ok, I've got a stupid bash script which lets us decide whether to update automatically. Should be easy to connect that to GHA input/output to make the PR conditional on that. But I ran out of time today before heading off for two weeks. Happy for someone to pick it up and finish it, or I can look when I'm back. |
| dest = root / "build" | ||
|
|
||
| args = ["-b", builder, "-d", dest / "doctrees"] | ||
| args = ["-b", builder, "-d", dest / "doctrees", "-wtest.txt"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs moving out into a flagged parameter so it doesn't happen with every build.
|
I've not looked into the Python version build error. |
I did look at Dependabot, but I don't think it quite works for this scenario.