Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDAV configuration isn't working in windows #1163

Closed
douglasparker opened this issue Jun 8, 2024 · 4 comments · Fixed by #1241
Closed

WebDAV configuration isn't working in windows #1163

douglasparker opened this issue Jun 8, 2024 · 4 comments · Fixed by #1241
Assignees
Labels
A-config Area: Related to the config file functionality and format C-invalid Category: This doesn't seem right

Comments

@douglasparker
Copy link

Tested with latest and rustic v0.7.0-45-gfc8e3c5-nightly

rustic webdav binds to http://[::1]:8000 despite the configuration.

[webdav]
address = "127.0.0.1:8000"
path-template = "[{hostname}]/[{label}]/{time}" # The path template to use for snapshots. {id}, {id_long}, {time}, {username}, {hostname}, {label}, {tags}, {backup_start}, {backup_end} are replaced. [default: "[{hostname}]/[{label}]/{time}"]. Only relevant if no snapshot-path is given.
time-template = "%Y-%m-%d_%H-%M-%S"
symlinks = false
file-access = "read"
@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Jun 8, 2024
@nardoor
Copy link
Contributor

nardoor commented Aug 20, 2024

Hello @douglasparker ,

To me, the address [::1] is the IPv6 equivalent of localhost (same as 127.0.0.1 for IPv4).

Are you certain that you can't connect to the webdav using 127.0.0.1:8000 when rustic says that it binds on http://[::1]:8000?
I'm assuming it should work, let me know if I am being wrong.

@nardoor nardoor added the A-config Area: Related to the config file functionality and format label Aug 20, 2024
@douglasparker
Copy link
Author

@nardoor Yep, I'm certain. Feel free to test it out yourself.

@KamikazeePL
Copy link

On Windows 10 home it sometimes can not connect from Explorer but WinSCP I can connect and browse and copy files.

@nardoor nardoor self-assigned this Sep 17, 2024
@nardoor nardoor added C-invalid Category: This doesn't seem right and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Sep 17, 2024
nardoor pushed a commit that referenced this issue Sep 17, 2024
The `inner_run` implementation used `self`
to read its config when it should use `RUSTIC_APP.config()`.

Some might say this is counterintuitive.
fixes #1163
@nardoor
Copy link
Contributor

nardoor commented Sep 17, 2024

@nardoor Yep, I'm certain. Feel free to test it out yourself.

This indeed was a bug, thanks for reporting. I apologize for taking so long to fix it.

rustic totally ignored the toml config.
#1241 fixes it

github-merge-queue bot pushed a commit that referenced this issue Sep 18, 2024
The `inner_run` implementation used `self`
to read its config when it should use `RUSTIC_APP.config()`.

Some might say this is counterintuitive.
fixes #1163
also now correctly respects having `prune = true` in the config profile.

---------

Co-authored-by: Alexander Weiss <[email protected]>
Co-authored-by: simonsan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config Area: Related to the config file functionality and format C-invalid Category: This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants