fix: webdav/forget: correctly use application config #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `inner_run` implementation used `self` to read its config when it should use `RUSTIC_APP.config()`. Some might say this is counterintuitive.
|
@aawsome @simonsan I wish |
aawsome
changed the title
In commands that have configurations from the ENV and the TOML (on top of CLI), a confusion between RUSTIC_APP.config() and &self (see `inner_run` impls) could lead to parts of the user configured options to be ignored. For now we warn about this in the code. But some design change should be decided in order to avoid these risks in the future.
nardoor
force-pushed
the
fix/webdav_configuration_bug
branch
from
296cc14
to
60f7ec9
Compare
aawsome
previously approved these changes
Sep 18, 2024
simonsan
reviewed
Sep 18, 2024
simonsan
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inner_runimplementation usedselfto read its config when it should use
RUSTIC_APP.config().Some might say this is counterintuitive.
fixes #1163
also now correctly respects having
prune = truein the config profile.