Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webdav/forget: correctly use application config #1241

Merged
merged 4 commits into from
Sep 18, 2024

Commits on Sep 17, 2024

  1. fix(webdav): correctly use application config

    The `inner_run` implementation used `self`
    to read its config when it should use `RUSTIC_APP.config()`.
    
    Some might say this is counterintuitive.
    nardoor committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cba0359 View commit details
    Browse the repository at this point in the history
  2. fix identical bug in forget

    aawsome committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6134e93 View commit details
    Browse the repository at this point in the history
  3. warn: warn about RUSTIC_APP.config() vs self usage

    In commands that have configurations from
    the ENV and the TOML (on top of CLI),
    a confusion between RUSTIC_APP.config()
    and &self (see `inner_run` impls) could
    lead to parts of the user configured options
    to be ignored.
    
    For now we warn about this in the code.
    But some design change should be decided
    in order to avoid these risks in the future.
    nardoor committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    60f7ec9 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    e1bbcf3 View commit details
    Browse the repository at this point in the history