Skip to content

ls: Add options --summary and --long

Sign in for the full log view
GitHub Actions / Clippy Output failed Jul 17, 2023 in 0s

Clippy Output

14 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 14
Warning 0
Note 0
Help 0

Versions

  • rustc 1.71.0 (8ede3aae2 2023-07-12)
  • cargo 1.71.0 (cfd3bbd8f 2023-06-08)
  • clippy 0.1.71 (8ede3aa 2023-07-12)

Annotations

Check failure on line 128 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

empty String is being created manually 

error: empty String is being created manually
   --> src/commands/ls.rs:128:13
    |
128 |             "".to_string()
    |             ^^^^^^^^^^^^^^ help: consider using: `String::new()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new
    = note: `-D clippy::manual-string-new` implied by `-D warnings`

Check failure on line 128 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

empty String is being created manually 

error: empty String is being created manually
   --> src/commands/ls.rs:128:13
    |
128 |             "".to_string()
    |             ^^^^^^^^^^^^^^ help: consider using: `String::new()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new
    = note: `-D clippy::manual-string-new` implied by `-D warnings`

Check failure on line 124 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:124:14
    |
124 |             .unwrap_or("?".to_string()),
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 119 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:119:33
    |
119 |         node.meta.group.clone().unwrap_or("?".to_string()),
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 118 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:118:32
    |
118 |         node.meta.user.clone().unwrap_or("?".to_string()),
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 116 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

redundant closure 

error: redundant closure
   --> src/commands/ls.rs:116:18
    |
116 |             .map(|m| parse_permissions(m))
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_permissions`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `-D clippy::redundant-closure` implied by `-D warnings`

Check failure on line 117 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:117:14
    |
117 |             .unwrap_or("?????????".to_string()),
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?????????".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
    = note: `-D clippy::or-fun-call` implied by `-D warnings`

Check failure on line 124 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:124:14
    |
124 |             .unwrap_or("?".to_string()),
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 94 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

consider adding a `;` to the last statement for consistent formatting 

error: consider adding a `;` to the last statement for consistent formatting
  --> src/commands/ls.rs:91:13
   |
91 | /             println!(
92 | |                 "total: {} dirs, {} files, {} bytes",
93 | |                 summary.dirs, summary.files, summary.size
94 | |             )
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
   = note: `-D clippy::semicolon-if-nothing-returned` implied by `-D warnings`
help: add a `;` here
   |
91 ~             println!(
92 +                 "total: {} dirs, {} files, {} bytes",
93 +                 summary.dirs, summary.files, summary.size
94 +             );
   |

Check failure on line 119 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:119:33
    |
119 |         node.meta.group.clone().unwrap_or("?".to_string()),
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 118 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:118:32
    |
118 |         node.meta.user.clone().unwrap_or("?".to_string()),
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

Check failure on line 116 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

redundant closure 

error: redundant closure
   --> src/commands/ls.rs:116:18
    |
116 |             .map(|m| parse_permissions(m))
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_permissions`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `-D clippy::redundant-closure` implied by `-D warnings`

Check failure on line 117 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

use of `unwrap_or` followed by a function call 

error: use of `unwrap_or` followed by a function call
   --> src/commands/ls.rs:117:14
    |
117 |             .unwrap_or("?????????".to_string()),
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?????????".to_string())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
    = note: `-D clippy::or-fun-call` implied by `-D warnings`

Check failure on line 94 in src/commands/ls.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

consider adding a `;` to the last statement for consistent formatting 

error: consider adding a `;` to the last statement for consistent formatting
  --> src/commands/ls.rs:91:13
   |
91 | /             println!(
92 | |                 "total: {} dirs, {} files, {} bytes",
93 | |                 summary.dirs, summary.files, summary.size
94 | |             )
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
   = note: `-D clippy::semicolon-if-nothing-returned` implied by `-D warnings`
help: add a `;` here
   |
91 ~             println!(
92 +                 "total: {} dirs, {} files, {} bytes",
93 +                 summary.dirs, summary.files, summary.size
94 +             );
   |
View more details on GitHub Actions