Clippy Output
49 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 49 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.71.0 (8ede3aae2 2023-07-12)
- cargo 1.71.0 (cfd3bbd8f 2023-06-08)
- clippy 0.1.71 (8ede3aa 2023-07-12)
Annotations
Check failure on line 825 in crates/rustic_core/src/repository.rs
github-actions / Clippy Output
backticks are unbalanced
error: backticks are unbalanced
--> crates/rustic_core/src/repository.rs:823:5
|
823 | / /// If `node` is a tree node, this will list the content of that tree.
824 | | /// If `node` is a file node, this will only return one element.
825 | | /// Note that the `PathBuf` returned will be relative to the given 'node`.
| |______________________________________________________________________________^
|
= help: a backtick may be missing a pair
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
Check failure on line 811 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:811:29
|
811 | /// Returns whether the PathList is empty.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
811 | /// Returns whether the `PathList` is empty.
| ~~~~~~~~~~
Check failure on line 805 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:805:32
|
805 | /// Number of paths in the PathList.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
805 | /// Number of paths in the `PathList`.
| ~~~~~~~~~~
Check failure on line 796 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:796:18
|
796 | /// Create a PathList by parsing a Strings containing paths separated by whitspaces.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
796 | /// Create a `PathList` by parsing a Strings containing paths separated by whitspaces.
| ~~~~~~~~~~
Check failure on line 782 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:782:18
|
782 | /// Create a PathList from Strings.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
782 | /// Create a `PathList` from Strings.
| ~~~~~~~~~~
Check failure on line 766 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:766:43
|
766 | /// PathList is a rustic-internal list of PathBufs. It is used in the [`crate::Repository::backup`] command.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
766 | /// PathList is a rustic-internal list of `PathBufs`. It is used in the [`crate::Repository::backup`] command.
| ~~~~~~~~~~
Check failure on line 766 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:766:5
|
766 | /// PathList is a rustic-internal list of PathBufs. It is used in the [`crate::Repository::backup`] command.
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
766 | /// `PathList` is a rustic-internal list of PathBufs. It is used in the [`crate::Repository::backup`] command.
| ~~~~~~~~~~
Check failure on line 759 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:759:14
|
759 | /// Turn StringList into an Iterator
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
759 | /// Turn `StringList` into an Iterator
| ~~~~~~~~~~~~
Check failure on line 671 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
item in documentation is missing backticks
error: item in documentation is missing backticks
--> crates/rustic_core/src/repofile/snapshotfile.rs:671:5
|
671 | /// StringList is a rustic-internal list of Strings. It is used within [`SnapshotFile`]
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
671 | /// `StringList` is a rustic-internal list of Strings. It is used within [`SnapshotFile`]
| ~~~~~~~~~~~~
Check failure on line 627 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
missing documentation for a struct field
error: missing documentation for a struct field
--> crates/rustic_core/src/repofile/snapshotfile.rs:627:5
|
627 | pub tags: Option<StringList>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 626 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
missing documentation for a struct field
error: missing documentation for a struct field
--> crates/rustic_core/src/repofile/snapshotfile.rs:626:5
|
626 | pub paths: Option<StringList>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 625 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
missing documentation for a struct field
error: missing documentation for a struct field
--> crates/rustic_core/src/repofile/snapshotfile.rs:625:5
|
625 | pub label: Option<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 624 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
missing documentation for a struct field
error: missing documentation for a struct field
--> crates/rustic_core/src/repofile/snapshotfile.rs:624:5
|
624 | pub hostname: Option<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 300 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
useless conversion to the same type: `std::string::String`
error: useless conversion to the same type: `std::string::String`
--> crates/rustic_core/src/repofile/snapshotfile.rs:300:26
|
300 | command: command.into(),
| ^^^^^^^^^^^^^^ help: consider removing `.into()`: `command`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
Check failure on line 292 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
use Option::map_or_else instead of an if let/else
error: use Option::map_or_else instead of an if let/else
--> crates/rustic_core/src/repofile/snapshotfile.rs:285:31
|
285 | let command: String = if let Some(command) = &opts.command {
| _______________________________^
286 | | command.clone()
287 | | } else {
288 | | std::env::args_os()
... |
291 | | .join(" ")
292 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_if_let_else
= note: `-D clippy::option-if-let-else` implied by `-D warnings`
help: try
|
285 ~ let command: String = opts.command.as_ref().map_or_else(|| std::env::args_os()
286 + .map(|s| s.to_string_lossy().to_string())
287 + .collect::<Vec<_>>()
288 ~ .join(" "), |command| command.clone());
|
Check failure on line 275 in crates/rustic_core/src/repofile/snapshotfile.rs
github-actions / Clippy Output
use of `unwrap_or` followed by a function call
error: use of `unwrap_or` followed by a function call
--> crates/rustic_core/src/repofile/snapshotfile.rs:275:30
|
275 | let time = opts.time.unwrap_or(Local::now());
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Local::now)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
= note: `-D clippy::or-fun-call` implied by `-D warnings`
Check failure on line 47 in crates/rustic_core/src/repofile/packfile.rs
github-actions / Clippy Output
this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
--> crates/rustic_core/src/repofile/packfile.rs:47:29
|
47 | pub(crate) fn to_binary(&self) -> RusticResult<Vec<u8>> {
| ^^^^^ help: consider passing by value instead: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
Check failure on line 47 in crates/rustic_core/src/repofile/packfile.rs
github-actions / Clippy Output
methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
error: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> crates/rustic_core/src/repofile/packfile.rs:47:29
|
47 | pub(crate) fn to_binary(&self) -> RusticResult<Vec<u8>> {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
Check failure on line 33 in crates/rustic_core/src/repofile/packfile.rs
github-actions / Clippy Output
this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
error: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
--> crates/rustic_core/src/repofile/packfile.rs:33:32
|
33 | pub(crate) const fn to_u32(&self) -> u32 {
| ^^^^^ help: consider passing by value instead: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
= note: `-D clippy::trivially-copy-pass-by-ref` implied by `-D warnings`
Check failure on line 33 in crates/rustic_core/src/repofile/packfile.rs
github-actions / Clippy Output
methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
error: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> crates/rustic_core/src/repofile/packfile.rs:33:32
|
33 | pub(crate) const fn to_u32(&self) -> u32 {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
Check failure on line 51 in crates/rustic_core/src/progress.rs
github-actions / Clippy Output
missing documentation for a struct
error: missing documentation for a struct
--> crates/rustic_core/src/progress.rs:51:1
|
51 | pub struct NoProgressBars;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 35 in crates/rustic_core/src/progress.rs
github-actions / Clippy Output
missing documentation for a struct
error: missing documentation for a struct
--> crates/rustic_core/src/progress.rs:35:1
|
35 | pub struct NoProgress;
| ^^^^^^^^^^^^^^^^^^^^^
Check failure on line 23 in crates/rustic_core/src/progress.rs
github-actions / Clippy Output
missing documentation for an associated type
error: missing documentation for an associated type
--> crates/rustic_core/src/progress.rs:23:5
|
23 | type P: Progress;
| ^^^^^^^^^^^^^^^^
Check failure on line 37 in crates/rustic_core/src/error.rs
github-actions / Clippy Output
missing documentation for a method
error: missing documentation for a method
--> crates/rustic_core/src/error.rs:37:5
|
37 | pub fn into_inner(self) -> RusticErrorKind {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 33 in crates/rustic_core/src/error.rs
github-actions / Clippy Output
missing documentation for a struct
error: missing documentation for a struct
--> crates/rustic_core/src/error.rs:33:1
|
33 | pub struct RusticError(#[from] RusticErrorKind);
| ^^^^^^^^^^^^^^^^^^^^^^