feat: Add new options to rclone backend #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aawsome
force-pushed
the
rclone-command
branch
2 times, most recently
from
7378592
to
6b3db8f
Compare
|
Looks good to me! 🚀 EDIT: Misread something, so it's fine now. |
simonsan
approved these changes
Jan 28, 2024
This was referenced Jan 28, 2024
aawsome
added a commit
that referenced
this pull request
Jan 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Add more access methods to repository * fixup access * make more node properties public * add caching * add vfs * use dav_server * remove fuse * fix lints * update dav-server * dont't expose cache type * Add file policy to Vfs * fixup dump.rs * fix clippy lints * Adjust API * feat: Add options rclone-command, use-password, rest-url to rclone backend (#139) * docs: fix typo Signed-off-by: simonsan <[email protected]> * allow to use FilePolicy in clap * prevent potential bug about unparitioned vec * fix seek value after reading * add some docs * dprint lint * refactor: extract constants to own module Signed-off-by: simonsan <[email protected]> * fix: typo Signed-off-by: simonsan <[email protected]> * docs: add docs for constants Signed-off-by: simonsan <[email protected]> * docs: add TODO for missing Errors, add some docs Signed-off-by: simonsan <[email protected]> * refactor: error handling in vfs Signed-off-by: simonsan <[email protected]> * docs: add error doc Signed-off-by: simonsan <[email protected]> * use FilePolicy only in WebDavFs * docs: add todos for error handling Signed-off-by: simonsan <[email protected]> * fix: unreachable pub Signed-off-by: simonsan <[email protected]> * remove unwraps in vfs * fix: clippy Signed-off-by: simonsan <[email protected]> * style: cargo fmt Signed-off-by: simonsan <[email protected]> * docs: document more errors Signed-off-by: simonsan <[email protected]> * fix: sort enum variants alphabetically Signed-off-by: simonsan <[email protected]> * fix: sort enum variants alphabetically Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * fix: imports Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * docs: more docs Signed-off-by: simonsan <[email protected]> * chore: cleanup Signed-off-by: simonsan <[email protected]> --------- Signed-off-by: simonsan <[email protected]> Co-authored-by: simonsan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following options to the rclone backend:
rclone-command- to manually define the rclone command used. Default: "rclone serve restric --addr localhost:0".use-password- whether to generate and use user/password for the rclone rest conneciotn. Default: "true"rest-url- the rest URL to use. Default: Get URL from rclone outputAlso adds a better treatment for the spawned thread which outputs rclone errors. This closes #22 and rustic-rs/rustic#1006