-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deps): use conflate instead of merge crate #284
Conversation
Signed-off-by: simonsan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Removed/reverted the 'use provided hashmap strategy' commit, as that contains a breaking change for EDIT: Breaking change is in #291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## 🤖 New release * `rustic_backend`: 0.3.0 -> 0.4.0 (⚠️ API breaking changes) * `rustic_core`: 0.4.0 -> 0.5.0 (⚠️ API breaking changes) * `rustic_testing`: 0.2.1 -> 0.2.2 (✓ API compatible changes) ###⚠️ `rustic_backend` breaking changes ``` --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum LocalBackendErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:90 enum RestErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:67 enum BackendAccessErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:10 enum RcloneErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:43 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/function_missing.ron Failed in: function rustic_backend::choose::extend, previously in file /tmp/.tmpKTBBxT/rustic_backend/src/choose.rs:74 --- failure struct_marked_non_exhaustive: struct marked #[non_exhaustive] --- Description: A public struct has been marked #[non_exhaustive], which will prevent it from being constructed using a struct literal outside of its crate. It previously had no private fields, so a struct literal could be used to construct it outside its crate. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_marked_non_exhaustive.ron Failed in: struct BackendOptions in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/choose.rs:35 struct BackendOptions in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/choose.rs:35 ``` ###⚠️ `rustic_core` breaking changes ``` --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum LimitOption in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/prune.rs:253 --- failure struct_marked_non_exhaustive: struct marked #[non_exhaustive] --- Description: A public struct has been marked #[non_exhaustive], which will prevent it from being constructed using a struct literal outside of its crate. It previously had no private fields, so a struct literal could be used to construct it outside its crate. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_marked_non_exhaustive.ron Failed in: struct RestoreOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/restore.rs:49 struct RepoFileInfos in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:163 struct KeyOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/key.rs:17 struct BlobInfo in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:31 struct FileDirStats in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/restore.rs:74 struct CheckOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/check.rs:125 struct ConfigOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/config.rs:107 struct IndexInfos in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:17 struct PackInfo in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:64 struct TreeStreamerOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/blob/tree.rs:401 struct PruneOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/prune.rs:58 struct RepairSnapshotsOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repair/snapshots.rs:29 struct RestoreStats in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/restore.rs:90 struct RepoFileInfo in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:173 struct LocalSourceFilterOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/backend/ignore.rs:71 struct LocalSourceSaveOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/backend/ignore.rs:51 struct RepositoryOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/repository.rs:88 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `rustic_backend` <blockquote> ## [0.4.0](rustic_backend-v0.3.0...rustic_backend-v0.4.0) - 2024-10-02 ### Fixed - Add #[non_exhaustive] to pub structs which may be extended in future ([#293](#293)) - *(backend)* [**breaking**] Use correct merge stratgy for repository options ([#291](#291)) ### Other - *(deps)* update dependencies ([#292](#292)) - *(deps)* use conflate instead of merge crate ([#284](#284)) </blockquote> ## `rustic_core` <blockquote> ## [0.5.0](rustic_core-v0.4.0...rustic_core-v0.5.0) - 2024-10-02 ### Added - Add read-data-subset to CheckOptions; allow to check given trees ([#262](#262)) - Add Repository method to update snapshot collections ([#260](#260)) ### Fixed - Add #[non_exhaustive] to pub structs which may be extended in future ([#293](#293)) - Don't query the default cache directory when a custom one is set ([#285](#285)) ### Other - *(deps)* update dependencies ([#292](#292)) - *(deps)* use conflate instead of merge crate ([#284](#284)) </blockquote> ## `rustic_testing` <blockquote> ## [0.2.2](rustic_testing-v0.2.1...rustic_testing-v0.2.2) - 2024-10-02 ### Other - *(deps)* update dependencies ([#292](#292)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
conflate (essentially merge 0.1.0-dev) lacks the blanket
impl<T> Merge for Option<T>
, which was removed from version 0.1.0Hence, I added the
overwrite_none
strategies where needed.We could also add it back, for a future version, though I think there was some decision involved, that strategies should be more explicit, because it could be confusing for strategies being applied without having an annotation. So I felt, I don't want to add that back to
conflate
for now.Fixes #258