Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving to axum #40

Merged
merged 20 commits into from
Jan 22, 2024
Merged

moving to axum #40

merged 20 commits into from
Jan 22, 2024

Conversation

mundo-68
Copy link

@mundo-68 mundo-68 commented Jan 7, 2024

Lots of changes. More to do to get things working.
The idea is to also have testing of the server included.
Current already has a test to validate authentication.

@simonsan simonsan added A-meta Area: Project wide C-refactor Category: Refactoring of already existing code A-dependencies Area: Pull requests that update a dependency file labels Jan 7, 2024
simonsan
simonsan requested changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@simonsan simonsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking through it, some things still need to be fixed. Then we can merge it and let the cross-ci run against it. After that, in the other PR aawsome should take a look as well, if everything is fine. 👍🏽

.cargo/config.toml Outdated Show resolved Hide resolved
config/rustic_config.toml Show resolved Hide resolved
src/commands/serve.rs Show resolved Hide resolved
src/config/auth_file.rs Outdated Show resolved Hide resolved
src/handlers/file_exchange.rs Show resolved Hide resolved
src/handlers/files_list.rs Show resolved Hide resolved
src/handlers/path_analysis.rs Show resolved Hide resolved
tests/test_server.rs Outdated Show resolved Hide resolved
@simonsan simonsan mentioned this pull request Jan 22, 2024
Open
@simonsan simonsan merged commit 2aba503 into rustic-rs:feature/axum Jan 22, 2024
7 checks passed
simonsan pushed a commit that referenced this pull request Jan 23, 2024
@mundo-68 @simonsan
refactor!: moving to axum (#40)
4771de6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsan simonsan simonsan approved these changes

Assignees
No one assigned
Labels
A-dependencies Area: Pull requests that update a dependency file A-meta Area: Project wide C-refactor Category: Refactoring of already existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mundo-68 @simonsan