aws-lc-rs prebuilt-nasm, update cargo check external types nightly version #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the upstream release notes: https://github.com/awslabs/cargo-check-external-types/releases/tag/v0.1.13
Upstream Rustls has done this since 0.23.13. This feature makes aws-lc-rs more like Ring w.r.t to its ASM artifacts on Windows and allows removing the NASM install in CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 20 20
Lines 4225 4225
=======================================
Hits 4108 4108
Misses 117 117 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Nov 1, 2024
djc
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo: activate aws-lc-rs prebuilt-nasm feature
Upstream Rustls has done this since 0.23.13. This prebuilt-nasm feature makes aws-lc-rs more like Ring w.r.t to its ASM artifacts on Windows and allows removing the NASM install in CI.
ci: adjust nightly for cargo-check-external-types
See the upstream v0.1.13 release notes.