Skip to content

Add advisory for rust-lang/rust#78498 #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add advisory for rust-lang/rust#78498 #561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e76d3d
Report string::retain() bug
Qwaz Jan 13, 2021
dfc2278
Use std instead of alloc
Qwaz Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions rust/std/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "std"
date = "2020-10-28"
url = "https://github.com/rust-lang/rust/issues/78498"

[affected.functions]
"std::string::String::retain" = ["< 1.49.0, >= 1.26.0"]

[versions]
patched = [">= 1.49.0"]
unaffected = ["< 1.26.0"]
```

# `String::retain()` may return non-UTF-8 string when the predicate closure panics

The affected version of the Rust standard library shipped `String::retain()` that is not panic safe.
The affected version of this API
may leave the string in non-UTF-8 status if the provided predicate closure panics in the middle of the iteration.
The standard library has an invariant that assumes all strings are UTF-8 encoded,
so it could lead to a safety violation if that invalid string is used again in the unwinding path.
The bug was fixed by truncating the string before the iteration.
It now returns an empty string when the predicate panics.