Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binding for Date.to_locale_time_string_with_options #4384

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Add binding for Date.to_locale_time_string_with_options #4384

merged 4 commits into from
Jan 7, 2025

Conversation

paul-hansen
Copy link
Contributor

@paul-hansen paul-hansen commented Dec 27, 2024 •
edited
Loading

Closes #4383

@paul-hansen

This comment was marked as resolved.

Sign in to view
@paul-hansen

This comment was marked as outdated.

Sign in to view
@paul-hansen paul-hansen force-pushed the to_local_time_string_options branch from df956a0 to 33edc25 Compare December 27, 2024 18:51
daxpedda
daxpedda requested changes Jan 4, 2025
View reviewed changes
crates/js-sys/src/lib.rs Outdated Show resolved Hide resolved
@daxpedda daxpedda added assigned This issue has been assigned to a contributor waiting for author Waiting for author to respond and removed assigned This issue has been assigned to a contributor labels Jan 4, 2025
@paul-hansen paul-hansen changed the title Add options parameter to Date.to_locale_time_string Add binding for Date.to_locale_time_string_with_options Jan 4, 2025
@paul-hansen paul-hansen requested a review from daxpedda January 4, 2025 20:29
daxpedda
daxpedda reviewed Jan 7, 2025
View reviewed changes
crates/js-sys/src/lib.rs
pub fn to_locale_time_string_with_options(
this: &Date,
locale: &str,
options: &JsValue,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options: &JsValue,
options: Option<&Object>,

Is probably more accurate, again, deviating more from the to_local_time(). So lets just leave it for the next breaking change.

daxpedda
daxpedda approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda daxpedda merged commit d59de5c into rustwasm:main Jan 7, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
waiting for author Waiting for author to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing "options" parameter from Date.to_locale_time_string
2 participants
@paul-hansen @daxpedda