Add binding for Date.to_locale_time_string_with_options
#4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
paul-hansen
force-pushed
the
to_local_time_string_options
branch
from
df956a0 to
33edc25
Compare
daxpedda
requested changes
Jan 4, 2025
daxpedda
added
assigned
paul-hansen
changed the title
Date.to_locale_time_stringDate.to_locale_time_string_with_options
daxpedda
reviewed
Jan 7, 2025
| pub fn to_locale_time_string_with_options( | ||
| this: &Date, | ||
| locale: &str, | ||
| options: &JsValue, |
There was a problem hiding this comment.
Suggested change
| options: &JsValue, | |
| options: Option<&Object>, |
Is probably more accurate, again, deviating more from the to_local_time(). So lets just leave it for the next breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4383