Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TypeScript to verify CLI reference output #4311

Merged
merged 6 commits into from
Dec 7, 2024
Merged

Use TypeScript to verify CLI reference output #4311

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e036505
Use TypeScript to verify CLI reference output
RunDevelopment Nov 30, 2024
1cd620e
Commands should work now
RunDevelopment Nov 30, 2024
49cff7d
No cd
RunDevelopment Nov 30, 2024
7d29dc5
No JS check
RunDevelopment Nov 30, 2024
4a1de2e
Merge branch 'main' into tsc-reference-output
RunDevelopment Dec 7, 2024
c378d1d
Use latest LTS
RunDevelopment Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- run: rustup update --no-self-update stable && rustup default stable
- run: rustup component add rustfmt
- run: cargo fmt --all -- --check

# Check TOML style by using Taplo.
taplo:
name: Taplo
Expand Down Expand Up @@ -239,6 +239,22 @@ jobs:
# WBINDGEN_I_PROMISE_JS_SYNTAX_WORKS_IN_NODE: 1
# - run: cargo build --manifest-path crates/web-sys/Cargo.toml --target wasm32-unknown-unknown --features "Node Window Document"

# This checks that the output of the CLI is actually valid JavaScript and TypeScript
test_cli_reference_typescript:
name: Run CLI reference TypeScript check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20'
RunDevelopment marked this conversation as resolved.
Show resolved Hide resolved
- run: npm i -g typescript
- run: npm i --save @types/node @types/deno
- name: Check TypeScript output
run: tsc --noEmit --skipLibCheck --lib esnext,dom $(echo crates/cli/tests/reference/*.d.ts)
daxpedda marked this conversation as resolved.
Show resolved Hide resolved
- name: Check JavaScript output
run: tsc --noEmit --skipLibCheck --lib esnext,dom --module esnext --allowJs $(echo crates/cli/tests/reference/*.js)

test_native:
name: Run native tests
runs-on: ubuntu-latest
Expand Down