return exitcode instead of bool #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondot
reviewed
Jun 27, 2022
bumblefoot/src/bin/cmd/default.rs
Outdated
| log::info!("default cmd {:?}", matches.value_of("reporter")); | ||
| println!("going to run {}", bumblefoot::CMD); | ||
| bumblefoot::run(); | ||
| Ok(true) | ||
| bumblefoot::CmdExit { |
There was a problem hiding this comment.
Maybe we try returning Result? the reason I'm suggesting is because it would make it easier to write error producing code such as IO, network and more (e.g. opening files, etc.) and using ? freely.
There was a problem hiding this comment.
yup, it sounds more flexible.
the CMD commands return Result<bumblefoot::CmdExit>.
the exit logic is
If Ok, take the CmdExit, print the text result if it exists, and exit with the given exit code
If Err log the error and exit with the default const configuration
jondot
reviewed
Jun 28, 2022
jondot
reviewed
Jun 28, 2022
jondot
reviewed
Jun 28, 2022
|
|
||
| #[derive(Debug, Serialize, Deserialize)] | ||
| pub struct Definitions { | ||
| pub providers: HashMap<String, String>, | ||
| } | ||
|
|
||
| pub struct CmdExit { |
Co-authored-by: Dotan J. Nahum <[email protected]>
Co-authored-by: Dotan J. Nahum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #6 issue, i have change the cmd return value from bool to exitcode
Also added the option to pass a custom message with different style depending on the exit code