feat: Allowing the option to skip the creation of the wallet in bitcoind #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/options-wallet
branch
from
46dd576
to
399a24c
Compare
A few years ago, I added this code for compatibility with Bitcoin Core 21. Now that I am integrating it with the LDK node runner, and LDK can use a wallet to set up a node with Bitcoin Core, we need a way to disable the wallet from Bitcoin Core to keep our integration simpler. Without this change, Bitcoin Core would have two wallets, and we would need to set up the correct wallet in our architecture. However, we can simply disable it to avoid this issue. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/options-wallet
branch
from
399a24c
to
45711de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago, I added this code for compatibility with Bitcoin Core 21.
Now that I am integrating it with the LDK node runner, and LDK can use a wallet to set up a node with Bitcoin Core, we need a way to disable the wallet from Bitcoin Core to keep our integration simpler.
Without this change, Bitcoin Core would have two wallets, and we would need to set up the correct wallet in our architecture.
However, we can simply disable it to avoid this issue.
Fixes #102