fix: work-around game creating creeps with id of type number #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to happen on spawn & swamp but not on ctf mode. documentation states that creep.id is of type string, so this is a bug in the game. work-around for rustyscreeps#4
shanemadden
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to happen on spawn & swamp but not on ctf mode. documentation states that creep.id is of type string, so this is a bug in the game.
work-around for #4
I thought about solving this from javascript side (by adding a method to creep prototype which returns calls creep.id.toString() and returning that). However the api doesn't provide any javascript so I did the fix on the rust side - in the case where a creep has a numeric id, this fix creates converts the number to a string on the rust side, then sends that to the js side to create a string so there is a small cost.