-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requesting merge of group-related exercises. #15
base: main
Are you sure you want to change the base?
Conversation
Add group, some field examples in python also merged two files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the math part, finite fields and modular arithmetic I think it can also be benefitial to have rust exercises but can we align better with what was already done: https://github.com/rutefig/zklings/blob/main/exercises/math/README.md
Instead of doing something from the beginning you can improve what is already done and add the rust exercises but respecting the structure that was done from the beginning pls. We can chat about this if you want
@@ -0,0 +1,28 @@ | |||
// Identity Property: There exists an element e in the group such that for every element a in the group, e * a = a * e = a. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add for the additive operation as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if we should make more clear that from a set we can make a group for the multiplicative operation and another group for the additive operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let me think about it and we can discuss it tomorrow whenever you are available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we haven't discussed this, have you thought about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been working on basically turning your previous modulo exercises into rust exercises.
I would then combine all exercises under a combined finite_fields folder rather than a math folder (math seems very general). I could also do it the other way around if you prefer.
So in that case the setup would be:
exercises/finite_fields/00_modulo
exercises/finite_fields/01_sets_and_groups
exercises/finite_fields/02_finite_fields
At the same time, I will adjust my exercises briefly to also use mod within the exercises to have a common theme that you also describe in the previous math README.
As for the additive operation, I wil also add it.
The exercises that we added explore group theory and the different group axioms.
We focus on group theory to enable developers to get a better intuition for finite fields. This might be pretty low level but for devs who would like to better understand the math behind finite fields, this will be helpful.
The finite field specific exercises will be added next week.