Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[safety-dance] Remove some unsound usages of unsafe #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[safety-dance] Remove some unsound usages of unsafe #19

wants to merge 3 commits into from

Commits on Aug 23, 2019

  1. Fix unsoundness in refresh_reader 

    `mem::uninitialized` is unsound; and if refresh reader code panicked
between the enclosing `mem::replace`s, the code would be dropping and
thus reading uninitalized memory.
Taking ownership in and back out is the most simple solution to the
problem.
    Daniel Henry-Mantilla committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    e24eb61 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2019

  1. Fixed soundness issue with vectors of uninit bytes

    @danielhenrymantilla
    danielhenrymantilla committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    9c947cc View commit details
    Browse the repository at this point in the history

  2. Fix bare_trait_object usage

    @danielhenrymantilla
    danielhenrymantilla committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    979fc90 View commit details
    Browse the repository at this point in the history