Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hang protection in esp_mqtt_client_destroy #577

Open
TheSomeMan opened this issue Jul 7, 2022 · 5 comments
Open

Implement hang protection in esp_mqtt_client_destroy #577

TheSomeMan opened this issue Jul 7, 2022 · 5 comments

Comments

@TheSomeMan
Copy link
Collaborator

Related task: #569
@TheSomeMan TheSomeMan self-assigned this Jul 7, 2022
@TheSomeMan TheSomeMan mentioned this issue Jul 7, 2022
Merged
@ojousima ojousima modified the milestones: 1.13.0, 1.14.0 Sep 7, 2022
@laurijamsa
Copy link
Member

Can we close this? Or what to do? No need to implement any time soon? @TheSomeMan

@TheSomeMan
Copy link
Collaborator Author

esp_mqtt_client_destroy can take more than 5 seconds which can cause the task watchdog triggering. To fix this, a simple workaround was applied - the task watchdog is disabled during esp_mqtt_client_destroy.
But it would be not to disable the task watchdog and implement proper protection.
This task is not critical, as far as I remember, we never faced with hanging in esp_mqtt_client_destroy.

@laurijamsa laurijamsa removed this from the 1.14.0 milestone Nov 9, 2022
@markoaamunkajo
Copy link
Collaborator

@TheSomeMan is this task still valid, should we discard this task?

@TheSomeMan
Copy link
Collaborator Author

@TheSomeMan is this task still valid, should we discard this task?

Yes, it is still valid.

@TheSomeMan
Copy link
Collaborator Author

Need to check what happened if mqtt task is freezed.

@TheSomeMan TheSomeMan modified the milestone: 1.15.0 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@laurijamsa @ojousima @TheSomeMan @markoaamunkajo