Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #569: Sometimes task watchdog got triggered after saving configuration if MQTT is active #570

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Fix #569: Sometimes task watchdog got triggered after saving configuration if MQTT is active #570

merged 5 commits into from
Jul 11, 2022

Conversation

TheSomeMan
Copy link
Collaborator

No description provided.

@TheSomeMan TheSomeMan requested a review from ojousima July 7, 2022 04:03
ojousima
ojousima approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@ojousima ojousima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ojousima ojousima self-requested a review July 7, 2022 13:28
@ojousima
Copy link
Member

ojousima commented Jul 7, 2022

Is there something that will detect if esp_mqtt_client_destroy(p_mqtt_data->p_mqtt_client); gets stuck?

@TheSomeMan
Copy link
Collaborator Author

Is there something that will detect if esp_mqtt_client_destroy(p_mqtt_data->p_mqtt_client); gets stuck?

Unfortunately no, but it can be implemented in the future. I created an issue: #577

ojousima
ojousima approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@ojousima ojousima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge as #577 is worked on

@TheSomeMan TheSomeMan merged commit f23ca82 into master Jul 11, 2022
@TheSomeMan TheSomeMan deleted the issue-569 branch July 11, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojousima ojousima ojousima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheSomeMan @ojousima