Adds support to change the top level directory for plugins #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't test locally due to #14 so not sure if the tests pass. Just wanted to throw this up for review. |
logicminds
force-pushed
the
plugins_dir
branch
6 times, most recently
from
ed71946 to
cd8cd13
Compare
* Fixes rvm#13 - use different plugin path * previously by default, pluginator would only look in the directory named plugins. While this is a great notion, many existing plugin systems do not follow this path. This attempts to allow the user to change the default plugins directory to something different. Example: lib/plugins/my_group/plugin_name.rb can now be lib/alt_plugins/my_group/plugin_name.rb.
|
great idea, I will try to provide feedback in next 9-10 hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously by default, pluginator would only look in the directory
named plugins. While this is a great notion, many existing plugin
systems do not follow this path.
This attempts to allow the user to change the default plugins
directory to something different.
Example: lib/plugins/my_group/plugin_name.rb can now be
lib/alt_plugins/my_group/plugin_name.rb.