Use s2n-quic rustls TLS builder instead of re-export #2768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See aws/s2n-quic#2173
The re-exported
rustls
module in s2n-quic is deprecated as ofs2n-quic 1.35.1
. This change migrates to using thes2n-quic
TLS builder instead, which will ensure the stability of the integration going forward.To support this migration, we added a couple new capabilities to s2n-quic:
with_prefer_server_cipher_suite_order
added in fix(s2n-quic-rustls): mark re-exported types as deprecated aws/s2n-quic#2176rustls
ignore_client_order
settingTo explain the other changes:
with_cipher_suites(DEFAULT_CIPHERSUITES)
,with_safe_default_kx_groups()
, andwith_safe_default_protocol_versions()
are all specified by default in the buildersession_storage
andticketer
were not doing anything in the existing code, as session resumption is not currently supported forrustls
ins2n-quic