Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use s2n-quic rustls TLS builder instead of re-export #2768

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

WesleyRosenblum
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum commented Apr 8, 2024

See aws/s2n-quic#2173

The re-exported rustls module in s2n-quic is deprecated as of s2n-quic 1.35.1. This change migrates to using the s2n-quic TLS builder instead, which will ensure the stability of the integration going forward.

To support this migration, we added a couple new capabilities to s2n-quic:

To explain the other changes:

  • with_cipher_suites(DEFAULT_CIPHERSUITES), with_safe_default_kx_groups(), and with_safe_default_protocol_versions() are all specified by default in the builder
  • session_storage and ticketer were not doing anything in the existing code, as session resumption is not currently supported for rustls in s2n-quic

@SergioBenitez SergioBenitez merged commit 07e4170 into rwf2:master Apr 10, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants