V1.2.1 #35
V1.2.1 #35
Conversation
|
closes #33 |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 3 3
===========================================
Files 1 1
Lines 7 7
===========================================
Hits 7 7 Continue to review full report at Codecov.
|
Dockerfile
Outdated
| USER las2peer | ||
| RUN chmod -R a+rwx /src | ||
| RUN chmod +x /src/docker-entrypoint.sh | ||
| RUN chmod +x gradlew && ./gradlew build --exclude-task test |
There was a problem hiding this comment.
why is the test task excluded?
docker-entrypoint.sh
Outdated
| function set_in_service_config { | ||
| sed -i "s?${1}[[:blank:]]*=.*?${1}=${2}?g" ${SERVICE_PROPERTY_FILE} | ||
| } | ||
| #cp $SERVICE_PROPERTY_FILE $SERVICE_PROPERTY_FILE |
There was a problem hiding this comment.
which line do you mean?
There was a problem hiding this comment.
The line that is commented out
docker-entrypoint.sh
Outdated
| function set_in_service_config { | ||
| sed -i "s?${1}[[:blank:]]*=.*?${1}=${2}?g" ${SERVICE_PROPERTY_FILE} | ||
| } | ||
| #cp $SERVICE_PROPERTY_FILE $SERVICE_PROPERTY_FILE |
There was a problem hiding this comment.
The line that is commented out
Dockerfile
Outdated
| EXPOSE $HTTPS_PORT | ||
| EXPOSE $LAS2PEER_PORT | ||
| RUN chmod +x /src/docker-entrypoint.sh | ||
| RUN chmod +x docker-entrypoint.sh |
There was a problem hiding this comment.
Either this line or the one above is not needed
Dockerfile
Outdated
| RUN chmod +x gradlew && ./gradlew build | ||
| #RUN dos2unix /src/docker-entrypoint.sh | ||
| #RUN dos2unix /src/etc/i5.las2peer.connectors.webConnector.WebConnector.properties | ||
| #RUN dos2unix /src/etc/i5.las2peer.services.servicePackage.akgService.properties |
There was a problem hiding this comment.
Maybe add a comment here telling users why this is commented out
Added template dockerfile
Updated core to version 1.2.1