Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve calculating method for width of indent line #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve calculating method for width of indent line #96

wants to merge 1 commit into from

Conversation

Jipok
Copy link

@Jipok Jipok commented Nov 5, 2020

They're too fat for me now. Before:
screenshot
After witch style.guide_width = 1 :
image

@Jipok
Copy link
Author

Jipok commented Nov 6, 2020

Perhaps I shouldn't produce unnecessary entities.
@rxi, why did you choose math.ceil(1 * SCALE)? This gives a thickness of 2 pixels already with SCALE == 1.01. Looks too thick even with my SCALE == 1.25
I suggest using math.floor(SCALE + 0.5). Then no additional option is required. The thickness will become 2 pixels after SCALE == 1.5. I checked it looks fine, much better than the current version.

@Jipok Jipok changed the title Make configurable width of indentguide line Improve calculating method for width of indent line Nov 6, 2020
Jipok pushed a commit to Jipok/lite-plugins that referenced this pull request Dec 10, 2021
@adamharrison
Merge pull request rxi#96 from Nightwing13/dev
4a72fc9 
Updated Julia Syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jipok