[WIP] Upgrade onmt to v.3.5.1 #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
This is a sister PR with rxn4chemistry/rxn-onmt-models#6
The goal is to drop depedency of fork rxn-onmt-py for the official OpenNMT v.3.5.1 and upgrade to python 3.11
Changes:
rxn-onmt-pyinsetup.cfgOnmtTrainCommand.save_to_config_cmdto dump cli arguments to aconfig.yamlon disk.This is because
onmt_train -config config,.yamlcompared toonmt_train -- <all_arguments, even defaults with default values>complains less about missing values for new arguments in v.3.5.0 likelora_layersorquant_layers. It is also the way it is advised.