Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update for stateful pages #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alpakaxaxa
Copy link

Hey ryannhg I am new to Elm and I am not a very thorough person. I got stuck using elm-spa right at the start when I wanted to create a stateful page because the modules were missing when I generated a Page.sandbox.

I had to run elm-spa gen in order to sort this and I had to ask in the Elm beginner Slack :) maybe the update is a bit clearer for people like me that don't really know what they are doing and don't have a very good memory!

Other than that, I have a question regarding the command $ elm-spa add / sandbox
The documentation says it generates

page : Shared.Model -> Request -> Page.With Model Msg page = Page.sandbox { init = init , update = update , view = view }

but actually it generates
page : Shared.Model -> Request.With Params -> Page.With Model Msg page shared req = Page.sandbox { init = init , update = update , view = view }
the difference is "Request.With Params" and "page shared req"

is this intentional or should the documentation be updated for this too?

Thank you so much for your project. As I got stuck so early I can't say anything about it but I am looking forward to trying it out.

Best, Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant