This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Force anonymous request so we have only published pages in menu nodes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drove me crazy! Depending on the current state of the toolbar (edit mode / published mode) the menu pool returns nodes with either draft page ids or published page ids. Which then are stored in the named menu. This means there will never be a node referencing a public page if the menu was created in edit mode... This pull request forces the menu pool to only return published pages as available nodes by simulating an anonymous request when asking the menu pool for nodes.