Blog post CMS

[5andu]

demo.mp4

[ryanckulp]

@5andu THANK YOU! a couple small requests before we merge:

1. we shouldn't need the trix.css file, this gets included by the library
2. there is some competing Trix styling inside both app/assets/stylesheets/application.tailwind.css and app/assets/stylesheets/actiontext.css. let's combine these into 1 file, either actiontext.css or a new blog.css for even more clarity. the application.tailwind.css file should just have tailwind overrides + extensions
3. tiny detail, but inside blog_posts/show the <% meta title: "#{@blog_post.title} %> (+ description) doesn't need "quoted" interpolation, just raw Ruby

[5andu]

@ryanckulp

1. I'm not using the default trix.css file, I have added custom styling in the file for the editor & content, removing it breaks the styles of the editor, as well as the custom spacing I added in content. Is it ok to keep the trix.css file?
   
   
   
   

2. I deleted the rich text related styles from app/assets/stylesheets/application.tailwind.css as they were unnecessary.

3. Fixed for the title & description, good catch thanks!

[ryanckulp]

@5andu there are definitely a few custom styles, but a lot of it is duplicate from the source. we want to only host overrides and extensions, not the source. this lets us update to our Trix version without concerns.

new styling example

original source

our trix.css

(cool)

duplication examples

original source

our trix.css (here)

original source

our trix.css

(notice how these look a bit different, but the variables are the same. and variable references are better than hard-coded)

next steps

we could just merge, then maybe i can help remove dupe code. my strategy would be to combine all the Trix source CSS into 1 file, then do a git diff between them, or use a web UI tool to visualize diffs.

lemme know what you think!

[5andu]

@ryanckulp I've deleted unnecessary classes and made the rich text more simple and functional. Here's a recap of my changes:

trix.improvements.mp4

[ryanckulp]

excellent work, thanks for the second push. merging.