Fix Start script caching issue #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandens
force-pushed
the
issue/41/start-script-bad-cache
branch
from
49db0c9 to
56a2c26
Compare
…gin start scripts task and the build cache
ryandens
force-pushed
the
issue/41/start-script-bad-cache
branch
from
56a2c26 to
8dc4b36
Compare
…k since we template the start script at generation time with information resolved off javaagent configuration Fixes #41
ryandens
force-pushed
the
issue/41/start-script-bad-cache
branch
from
8dc4b36 to
2085dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Create a failing test reproducing the issue and adds the
javaagentconfiguration as an input of theapplicationplugin'sstartScriptstask because this plugin templates the start script based on the files resolved in the javaagent configuration