Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.10 compat #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python 3.10 compat #40

wants to merge 1 commit into from

Conversation

exterm
Copy link
Contributor

@exterm exterm commented Mar 9, 2023

No description provided.

@mvarnold
Copy link

mvarnold commented Aug 14, 2023

For backwards compatibility, would recommend changing the import to something like this, rather than accessing the module on line 156.

try:
    from collections.abc import Mapping
except ImportError:
    from collections import Mapping

@exterm
Copy link
Contributor Author

exterm commented Nov 4, 2023

Fixed.

@exterm
Copy link
Contributor Author

exterm commented Feb 26, 2024

@mvarnold

@exterm
Copy link
Contributor Author

exterm commented Jun 24, 2024

@ryanjgallagher

@andyreagan
Copy link
Collaborator

andyreagan commented Jul 2, 2024

Looks good to me (thanks!!) and looks like I could merge this but a few thoughts:

  1. We don't have any github action running to confirm that the code changes work (I suppose I could just try locally)
  2. More importantly, probably, I don't have access to the pypi deploy (and this is also not automated) so just merging it wouldn't help. We need Ryan to deploy the change.

I'd recommend Ryan set up both of those just to make these changes more push-button in the future.

@exterm I sent a message to Ryan on our old Slack, I'll try to get it updated if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants