Add support for tracking modifierFlags on key events #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to track which modifier keys are currently pressed with the ability to differentiate left vs. right
eugenesvk
force-pushed
the
fr-evt-mod-bitflag
branch
from
7273939
to
8e8952f
Compare
eugenesvk
force-pushed
the
fr-evt-mod-bitflag
branch
from
8e8952f
to
a620a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing checking for left/right modifier key presses
Also adds a display impl to print those keys with nice ⇧⌥⌘ symbols and side indicators like
I'd replace the current EventModifierFlag enum with this bitflagy implementation, but then not sure what that one is used for, so left it as is and created a new enum
Also not sure why EventModifierFlag was duplicated in the appkit and events, couldn't it just be in 1 place in events and then Appkit would use that?
Anyway, for for now I've only added this to the Appkit as these are appkit apis