Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] NERDTree automatic refresh #224 #421

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

realSaltyFish
Copy link

@realSaltyFish realSaltyFish commented Dec 14, 2021

Requirements (please check off with 'x')

Note: The link to the Contributing Guidelines is broken.

What does this Pull Request (PR) do?

It fixes the bug reported in #224.

How should this be manually tested?

After applying this update, open NERDTree and create a new file. NERDTree will now automatically refresh and show the icon for the new file.

Any background context you can provide?

NERDTree buffers have buftype="nofile", so the CursorHoldUpdate() function will return prematurely when a NERDTree buffer is focused. This PR adds a buftype detection for NERDTree, preventing the return.

What are the relevant tickets (if any)?

#224

@ryanoasis
Copy link
Owner

Great and appreciate the contribution 🥇

I will have to pull it down and test it out...

Note: The link to the Contributing Guidelines is broken.

Thanks for catching that! Fixed!

@realSaltyFish
Copy link
Author

Hi, I added a commit to fix the style issues. Please review it, thanks!

@ryanoasis
Copy link
Owner

Sorry, I want to test this out locally. Need to get caught up

@cizordj
Copy link

cizordj commented Feb 25, 2022

I'm gonna help testing it out because I am having this issue as well

@cizordj
Copy link

cizordj commented Mar 5, 2022

I've been using this for a while and it does solve the problem, however it takes 5 or more seconds to refresh the icons and when I create new files in the root directory it doesn't refresh the icon sometimes.

@parkgang
Copy link

I'm waiting for that issue to be resolved. How is it going?

@cizordj
Copy link

cizordj commented Aug 4, 2023

@parkgang I'm no longer using nerd tree but you can try using this one instead: https://github.com/nvim-tree/nvim-tree.lua

@hungpham3112
Copy link

Can you merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants