-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] NERDTree automatic refresh #224 #421
base: master
Are you sure you want to change the base?
Conversation
Great and appreciate the contribution 🥇 I will have to pull it down and test it out...
Thanks for catching that! Fixed! |
Hi, I added a commit to fix the style issues. Please review it, thanks! |
Sorry, I want to test this out locally. Need to get caught up |
I'm gonna help testing it out because I am having this issue as well |
I've been using this for a while and it does solve the problem, however it takes 5 or more seconds to refresh the icons and when I create new files in the root directory it doesn't refresh the icon sometimes. |
I'm waiting for that issue to be resolved. How is it going? |
@parkgang I'm no longer using nerd tree but you can try using this one instead: https://github.com/nvim-tree/nvim-tree.lua |
Can you merge this PR? |
Requirements (please check off with 'x')
Note: The link to the Contributing Guidelines is broken.
What does this Pull Request (PR) do?
It fixes the bug reported in #224.
How should this be manually tested?
After applying this update, open NERDTree and create a new file. NERDTree will now automatically refresh and show the icon for the new file.
Any background context you can provide?
NERDTree buffers have
buftype="nofile"
, so theCursorHoldUpdate()
function will return prematurely when a NERDTree buffer is focused. This PR adds abuftype
detection for NERDTree, preventing the return.What are the relevant tickets (if any)?
#224