-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest coverage badge! #127
Conversation
Reviewer's Guide by SourceryThis pull request integrates Codecov into the CI workflow to report test coverage and adds a Codecov badge to the README. The main changes involve modifying the GitHub Actions workflow file to include Codecov for test coverage reporting and updating the README to display the coverage status. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ryansurf - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hard-coded Codecov token found in README. (link)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -1,5 +1,6 @@ | |||
![pytest](https://github.com/ryansurf/cli-surf/actions/workflows/pytest.yml/badge.svg) | |||
![linter](https://github.com/ryansurf/cli-surf/actions/workflows/linter.yml/badge.svg) | |||
[![codecov](https://codecov.io/github/ryansurf/cli-surf/graph/badge.svg?token=N8CAIUXMJG)](https://codecov.io/github/ryansurf/cli-surf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Hard-coded Codecov token found in README.
It's important to avoid exposing tokens in public files like README.md. Consider using environment variables or GitHub secrets to manage sensitive information.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ryansurf - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hard-coded Codecov token found in README. (link)
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
poetry config installer.max-workers 10 | ||
poetry install --no-interaction --no-ansi | ||
|
||
# - name: Run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Remove commented-out code
Consider removing the commented-out sections if they are no longer needed. This will improve the readability and maintainability of the workflow file.
@@ -1,5 +1,6 @@ | |||
![pytest](https://github.com/ryansurf/cli-surf/actions/workflows/pytest.yml/badge.svg) | |||
![linter](https://github.com/ryansurf/cli-surf/actions/workflows/linter.yml/badge.svg) | |||
[![codecov](https://codecov.io/github/ryansurf/cli-surf/graph/badge.svg?token=N8CAIUXMJG)](https://codecov.io/github/ryansurf/cli-surf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Hard-coded Codecov token found in README.
It's important to avoid exposing tokens in public files like README.md. Consider using environment variables or GitHub secrets to manage sensitive information.
General:
Code:
Summary by Sourcery
Integrate Codecov into the CI workflow to track test coverage and update the README with a Codecov badge.
New Features:
Enhancements:
CI:
Documentation: